Simplification

extensions/hooks/edit_alerts.py

@@ -64,54 +64,49 @@ from src.configloader import settings
 # }
 edit_alerts = settings.get("hooks", {}).get("edit_alerts", [])
 
+
+class RequirementNotMet(Exception):
+    pass
+
+
+def check_group_requirements(change_data: list, settings_data: list):
+    """This function resolves group discussions and raises RequirementNotMet when requirement is not met"""
+    if settings_data:
+        for required_group in settings_data:
+            for required_item in required_group:
+                if required_item not in change_data:
+                    raise RequirementNotMet
+
+
 @post_hook
 def edit_alerts_hook(message, metadata, context, change):
+    # For every alert in edit_alerts, they can have different functions and so on
     for alert in edit_alerts:
+        # For every requirement, if one of the requirements passes the alert gets executed
         for requirement in alert.get("requirements", []):
-            reqAction = requirement.get("action", [])
+            try:
-            if reqAction and context.event not in reqAction and context.event.split('/', 1)[0] not in reqAction:
+                req_action = requirement.get("action", [])
-                continue
+                # If current action isn't in config for this requirement AND current event type is not in the requirements in settings skip this requirement
-            reqUser = requirement.get("user", [])
+                if req_action and context.event not in req_action and context.event.split('/', 1)[0] not in req_action:
-            if reqUser and change["user"] not in reqUser and ("@__anon__" if "anon" in change else "@__user__") not in reqUser:
+                    raise RequirementNotMet
-                continue
+                req_user = requirement.get("user", [])
-            reqTitle = requirement.get("title", [])
+                # If current user is not in config AND checkings for anon and user fail
-            if reqTitle and change["title"] not in reqTitle:
+                if req_user and change["user"] not in req_user and ("@__anon__" if "anon" in change else "@__user__") not in req_user:
-                continue
+                    raise RequirementNotMet
-            if requirement.get("tags", []):
+                req_title = requirement.get("title", [])
-                for reqTags in requirement.get("tags", []):
+                if req_title and change["title"] not in req_title:
-                    for reqTag in reqTags:
+                    raise RequirementNotMet
-                        if reqTag not in change.get("tags", []):
+                check_group_requirements(change.get("tags", []), requirement.get("tags", []))
-                            break
-                    else:
-                        break
-                else:
-                    continue
                 if requirement.get("categories", []):
                     for reqCats in requirement.get("categories", []):
-                    if reqCats.get("added", []):
+                        check_group_requirements(context.categories.new, reqCats.get("added", []))
-                        for addedCats in reqCats.get("added", []):
+                        check_group_requirements(context.categories.new, reqCats.get("removed", []))
-                            for addedCat in addedCats:
+            except RequirementNotMet:
-                                if addedCat not in context.categories.new:
-                                    break
-                            else:
-                                break
-                        else:
                 continue
-                    if reqCats.get("removed", []):
-                        for removedCats in reqCats.get("removed", []):
-                            for removedCat in removedCats:
-                                if removedCat not in context.categories.removed:
-                                    break
             else:
                 break
         else:
             continue
-                    break
-                else:
-                    continue
-            break
-        else:
-            continue
         message.webhook_object["content"] = (message.webhook_object.get("content", "") or "") + alert["content"]
         allowed_mentions = message.webhook_object["allowed_mentions"]
         if alert.get("allowed_mentions", {}).get("users", []):