make function readable, fix copy paste error

This commit is contained in:
MarkusRost 2021-05-26 14:06:16 +00:00
parent 139385bd80
commit 0cd1b7ad74

View file

@ -75,8 +75,11 @@ def check_group_requirements(change_data: list, settings_data: list):
if settings_data: if settings_data:
for required_group in settings_data: for required_group in settings_data:
# test all items in required_group are in change_data (one group fulfills the requirement) return the function # test all items in required_group are in change_data (one group fulfills the requirement) return the function
if all([required_item in change_data for required_item in required_group]): for required_item in required_group:
return if required_item not in change_data:
continue
break
else:
raise RequirementNotMet raise RequirementNotMet
@ -103,8 +106,8 @@ def edit_alerts_hook(message, metadata, context, change):
if requirement.get("categories", []): if requirement.get("categories", []):
for req_cats in requirement.get("categories", []): for req_cats in requirement.get("categories", []):
try: try:
check_group_requirements(context.categories.new, reqCats.get("added", [])) check_group_requirements(context.categories.new, req_cats.get("added", []))
check_group_requirements(context.categories.removed, reqCats.get("removed", [])) check_group_requirements(context.categories.removed, req_cats.get("removed", []))
except RequirementNotMet: except RequirementNotMet:
continue continue
else: else: